[Webkit-unassigned] [Bug 205743] [WinCairo] Fixing build after "Add a pure virtual base class for GraphicsContext3D"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205743

Don Olmstead <don.olmstead at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #386708|review?                     |review+
              Flags|                            |

--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 386708
  --> https://bugs.webkit.org/attachment.cgi?id=386708
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386708&action=review

LGTM. Just making a note that I think we'll want to revisit some of these platform checks since they don't seem correct.

> Source/WebCore/platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp:483
> +#if (PLATFORM(GTK) && !USE(ANGLE)) || PLATFORM(WIN)

I think we maybe need a bug to audit these PLATFORM checks within the GraphicsContext3D stuff. The function glMapBufferRange is just OpenGL(ES) 3+ so this feels wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200103/19a2edba/attachment.htm>