[Webkit-unassigned] [Bug 203620] [SOUP] HSTS Support causes page loading to fail with "Operation was cancelled"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203620

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #386681|review?                     |review+
              Flags|                            |

--- Comment #16 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 386681
  --> https://bugs.webkit.org/attachment.cgi?id=386681
Patch

Aha, nice find!

One problem though: the user data parameter NetworkDataTaskSoup* task is passed to this callback using leakRef(), but now you've added this new early return before the ref is adopted, causing the task to leak. So this needs to go down below that at least. How about like this:

RefPtr<NetworkDataTaskSoup> protectedThis = adoptRef(task);
if (soupRequest != task->m_soupRequest.get()) {
    // ...
}
if (task->state() == State::Canceling || task->state() == State::Completed || !task->m_client) {
    // ...
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200103/e966b5a2/attachment-0001.htm>