[Webkit-unassigned] [Bug 207446] Web Inspector: request interception

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 29 10:06:57 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=207446

--- Comment #2 from Pavel Feldman <pfeldman at chromium.org> ---
(In reply to Devin Rousso from comment #1)
> We already have some of those commands (namely
> `Network.setInterceptionEnabled` and `Network.interceptWithResponse`).

I understand this and the fragment of the protocol above is on top of what you have. For example, it adds an 'interceptRequests' bit to the existing Network.setInterceptionEnabled. And it reuses the same Network.interceptWithResponse when client wants to fulfill request with the response.

>  Our initial design was to add a `"request"` value to `Network.NetworkStage` and
> likely a `Network.requestIntercepted` event

Yes, Network.requestIntercepted is exactly what I added in our fork.

> and `Network.interceptWithRequest` command.

This is something we called `Network.interceptContinue` in the protocol snippet. It allows augmenting method, headers and post data, but does not allow changing the target URL. Doing that would require serious surgery in the CachedResource, etc.

> Suffice to say, yes we're interested in adding request interception :)
> 

Sounds perfect.

> For more info about our current functionality/capabilities, you can read
> <https://webkit.org/web-inspector/local-overrides/>.

I surely did. If you are Ok roughly with the protocol changes outlined in my comment (and it sounds like you are), I am happy to attach the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200229/5c4ab808/attachment.htm>


More information about the webkit-unassigned mailing list