[Webkit-unassigned] [Bug 208192] [Curl] Add TLS debugging feature to log encryption keys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208192

Fujii Hironori <Hironori.Fujii at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #391853|review?                     |review+
              Flags|                            |

--- Comment #25 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 391853
  --> https://bugs.webkit.org/attachment.cgi?id=391853
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391853&action=review

LGTM

> Source/cmake/OptionsWinCairo.cmake:58
> +WEBKIT_OPTION_END()

WEBKIT_OPTION_END is already called in OptionsWin.cmake for WinCairo.
It seems that WEBKIT_OPTION_END shouldn't be called twice because FEATURE_DEFINES will get duplicated entries.
I think it should be moved into OptionsWin.cmake.

if (WTF_PLATFORM_WIN_CAIRO)
    WEBKIT_OPTION_DEFINE(ENABLE_TLS_DEBUG "Enable TLS key log support" PRIVATE ON)
endif ()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200227/84e22480/attachment.htm>