[Webkit-unassigned] [Bug 208192] [Curl] Add TLS debugging feature to log encryption keys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208192

--- Comment #22 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Alex Christensen from comment #19)
> Comment on attachment 391729 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391729&action=review
> 
> > Source/WebCore/platform/network/curl/CurlSSLVerifier.cpp:122
> > +    auto fp = fopen(CurlContext::singleton().tlsKeyLogFilePath().utf8().data(), "a");
> 
> Are you sure you want all this file I/O on the main thread?
> Is there an advantage to using wtf/FileSystem.h?

No, CurlSSLVerifier::infoCallback is invoked as a callback function in sub thread.

> 
> > Source/WebCore/platform/network/curl/CurlSSLVerifier.cpp:126
> > +    fprintf(fp, "CLIENT_RANDOM ");
> 
> Do you care about the return code?
> 

I think it doesn't seem to be necessary caring the return code.
Other parts using fprintf in WebKit also doesn't care.

> > Source/cmake/OptionsWinCairo.cmake:56
> > +WEBKIT_OPTION_DEFINE(ENABLE_TLS_DEBUG "Enable TLS key log support" PRIVATE ON)
> 
> You probably want to have this off by default.

Yes.
Even if the ON is preferable by default, disabling option could be useful for some developers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200227/bcf9d76c/attachment.htm>