[Webkit-unassigned] [Bug 208234] New: [GStreamer] Correctly remove webvttenc on WebKitTextCombiner pad release

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 26 04:29:50 PST 2020


            Bug ID: 208234
           Summary: [GStreamer] Correctly remove webvttenc on
                    WebKitTextCombiner pad release
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aboya at igalia.com
                CC: bugs-noreply at webkitgtk.org

The implementation of webkitTextCombinerReleasePad() was wrong in that
it was checking the peer pad of webkittextcombinerpad to check if it
belonged a webvttenc element and remove it... But since this is a
ghostpad, the peer is upstream, not downstream. When the release pad
function is called, upstream is already disconnected, so the branch
was never hit.

To actually remove the webvttenc element we must check the target pad
instead of the peer pad, which corresponds to the element downstream.
Also, we need to set the element state to NULL before removing it,
which the previous code didn't.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200226/3caf8610/attachment.htm>

More information about the webkit-unassigned mailing list