[Webkit-unassigned] [Bug 208192] [Curl] Add TLS debugging feature to log encryption keys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208192

--- Comment #9 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #5)
> Comment on attachment 391645 [details]
> Add TLS debugging feature.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391645&action=review
> 
> > Source/WebCore/platform/network/curl/CurlContext.h:131
> > +    bool shouldLogTlsKey() const { return !m_tlsKeyLogFilePath.isEmpty(); }
> 
> ‘Tls’ seems to violate WebKit coding style.
> https://webkit.org/code-style-guidelines/#names-basic
> TLS is better?

Fixed.

> 
> > Source/WebCore/platform/network/curl/CurlSSLVerifier.cpp:123
> > +    String line("CLIENT_RANDOM ");
> 
> do you need this temporary string? Why don’t you output by using fprintf?

Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200226/44f97e51/attachment.htm>