[Webkit-unassigned] [Bug 208115] Nullptr crash in WebCore::canHaveChildrenForEditing via CompositeEditCommand::insertNode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208115

--- Comment #11 from Jack <shihchieh_lee at apple.com> ---
Thanks! I thought about it but wondered if it is okay to listify contents if only the end is uneditable. Definitely it is more important to prevent crash!

(In reply to Ryosuke Niwa from comment #9)
> Comment on attachment 391660 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391660&action=review
> 
> > Source/WebCore/editing/InsertListCommand.cpp:341
> > -    if (start.isNull() || end.isNull())
> > +    if (start.isNull() || end.isNull() || !start.deepEquivalent().containerNode()->hasEditableStyle())
> 
> Sorry, I forgot to point out earlier but we should probably check that the
> end is also editable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200226/614aa5b4/attachment.htm>