[Webkit-unassigned] [Bug 208115] Nullptr crash in WebCore::canHaveChildrenForEditing via CompositeEditCommand::insertNode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 25 18:02:49 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=208115

--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 391660
  --> https://bugs.webkit.org/attachment.cgi?id=391660
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391660&action=review

> Source/WebCore/editing/InsertListCommand.cpp:341
> -    if (start.isNull() || end.isNull())
> +    if (start.isNull() || end.isNull() || !start.deepEquivalent().containerNode()->hasEditableStyle())

Sorry, I forgot to point out earlier but we should probably check that the end is also editable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200226/a0efb40f/attachment-0001.htm>


More information about the webkit-unassigned mailing list