[Webkit-unassigned] [Bug 208192] [Curl] Add TLS debugging feature

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 25 07:05:16 PST 2020


--- Comment #5 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 391645
  --> https://bugs.webkit.org/attachment.cgi?id=391645
Add TLS debugging feature.

View in context: https://bugs.webkit.org/attachment.cgi?id=391645&action=review

> Source/WebCore/platform/network/curl/CurlContext.h:131
> +    bool shouldLogTlsKey() const { return !m_tlsKeyLogFilePath.isEmpty(); }

‘Tls’ seems to violate WebKit coding style. https://webkit.org/code-style-guidelines/#names-basic
TLS is better?

> Source/WebCore/platform/network/curl/CurlSSLVerifier.cpp:123
> +    String line("CLIENT_RANDOM ");

do you need this temporary string? Why don’t you output by using fprintf?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200225/346ceedf/attachment.htm>

More information about the webkit-unassigned mailing list