[Webkit-unassigned] [Bug 207491] Add canShare function for Web Share API v2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207491

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #391588|review?                     |review+
              Flags|                            |

--- Comment #16 from Tim Horton <thorton at apple.com> ---
Comment on attachment 391588
  --> https://bugs.webkit.org/attachment.cgi?id=391588
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391588&action=review

> Source/WebCore/ChangeLog:9
> +        Added files member to share data and canShare function to
> +        navigator.cpp.

You should add some words here (about how canShare will return false if you have any files, etc.). Also, if it makes it easier to write lots of words, you can put them down below in the per-file comments.

> Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:616
> +// Defaults to false
> +WK_EXPORT void WKPreferencesSetWebShareFileAPIEnabled(WKPreferencesRef, bool flag);
> +WK_EXPORT bool WKPreferencesGetWebShareFileAPIEnabled(WKPreferencesRef);

Ditto what I said about legacy webkit: if there's no reason to add C SPI, we shouldn't.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200225/62fd9bb9/attachment-0001.htm>