[Webkit-unassigned] [Bug 208154] New: ImageBuffer should not use ImageData since this is a layer violation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 24 13:25:02 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=208154

            Bug ID: 208154
           Summary: ImageBuffer should not use ImageData since this is a
                    layer violation
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Canvas
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sabouhallawa at apple.com
                CC: dino at apple.com

ImageBuffer::getImageData() and ImageBuffer::puttImageData() deal with ImageData. Since ImageBuffer is in platform/graphics and ImageData is in html, this is considered a layering violation. The fix could be the following:

1. Move ImageData to platform/graphics except the DOM ImageData creation methods.
2. Add DOMImageData to html and make it inherit from ImageData.
3. Add the DOM ImageData creation methods to DOMImageData.
4. Rename ImageData.idl to DOMImageData.idl but make InterfaceName=ImageData.
5. Change all the DOM related reference to ImageData to be DOMImageData.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200224/85a7d648/attachment-0001.htm>


More information about the webkit-unassigned mailing list