[Webkit-unassigned] [Bug 208069] DocumentTimeline / CSSTransition objects are leaking on CNN.com

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208069

--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
(In reply to Chris Dumez from comment #6)
> (In reply to Chris Dumez from comment #5)
> > (In reply to Chris Dumez from comment #4)
> > > Created attachment 391544 [details]
> > > WIP Patch
> > 
> > Hmm, this patch seems to make it so that Document / Window objects are no
> > longer leaked. However, local testing seems to indicate that CSSTransition &
> > DocumentTimeline may still be leaked.
> 
> From memgraph, it is clear that the DocumentTimeline objects are staying
> because of the CSSTransition objects that are ref'ing them. It is however
> unclear to me what's keeping the CSSTransition objects alive.

Looking at the code though, it seems DocumentTimeline subclasses AnimationTimeline, which has various maps that ref the CSSTransition objects. Given that the CSSTransition objects ref their DocumentTimeline, it is pretty clear there is a cycle. It would be very easy to leak if the cycle does not get broken.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200224/22cae8f0/attachment-0001.htm>