[Webkit-unassigned] [Bug 207975] Crash in Page::updateRendering when document has no domWindow

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 20 17:41:47 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=207975

--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Said Abou-Hallawa from comment #3)
> Comment on attachment 391223 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391223&action=review
> 
> >> Source/WebCore/page/Page.cpp:1334
> >> +        if (document.domWindow()) {
> > 
> > Can we use an early return instead?
> 
> Should this be in forEachDocument()? Is there a reason to run any rendering
> update step for a document which does not have a window?

I don’t think we want to do that there because it’s used in other places than Page::updateRendering.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200221/85c52854/attachment.htm>


More information about the webkit-unassigned mailing list