[Webkit-unassigned] [Bug 207694] [WPE] Add support for rendering sliders for range elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207694

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 390637
  --> https://bugs.webkit.org/attachment.cgi?id=390637
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390637&action=review

>> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:368
>> +    if (part != SliderThumbHorizontalPart && part != SliderThumbVerticalPart)
> 
> Wouldn't it be enought here to use an assertion instead of a conditional
> statement? e.g.
> 
>   ASSERT(part == SliderThumbHorizontalPart || part == SliderThumbVerticalPart)

No, this can be called for other slider thumbs, like the media controls that we render differently. By not setting a size here for them we ensure RenderThemeWPE::paintSliderThumb() is not called fro them, that's why the assert is correct there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200220/ab9f7210/attachment.htm>