[Webkit-unassigned] [Bug 207694] [WPE] Add support for rendering sliders for range elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207694

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com
 Attachment #390637|review?                     |review+
              Flags|                            |

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 390637
  --> https://bugs.webkit.org/attachment.cgi?id=390637
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390637&action=review

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:368
> +    if (part != SliderThumbHorizontalPart && part != SliderThumbVerticalPart)

Wouldn't it be enought here to use an assertion instead of a conditional
statement? e.g.

  ASSERT(part == SliderThumbHorizontalPart || part == SliderThumbVerticalPart)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200220/1814f0be/attachment.htm>