[Webkit-unassigned] [Bug 207491] Add canShare function for Web Share API v2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207491

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #390658|                            |commit-queue-
              Flags|                            |

--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 390658
  --> https://bugs.webkit.org/attachment.cgi?id=390658
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390658&action=review

> Source/WebCore/ChangeLog:12
> +

In retrospect we probably need this to have an Experimental Feature flag. See WebPreferences.yaml, anything that's "category: experimental". You're OK without a build time flag, like I said before, but should still be a runtime-enabled experimental feature.

> Source/WebCore/page/Navigator.cpp:116
> +            // TODO: fix for when files fully implemented

Two options:

1) [Preferred] Remove this needless comment.
2) Make this comment a complete sentence, with capitalization and a period at the end (and maybe better grammar).

See https://webkit.org/code-style-guidelines/#comments

> LayoutTests/TestExpectations:736
> +# Web platform tests produce wrong failing results

This could do with a "why" (and ideally a reference to a bugzilla bug about fixing it!) instead of just "hey it's wrong"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200219/2e8fea9a/attachment.htm>