[Webkit-unassigned] [Bug 207875] Crash when Node::normalize() triggers mutation event that modifies child order

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 18 18:15:33 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=207875

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #391101|review?                     |review+
              Flags|                            |

--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 391101
  --> https://bugs.webkit.org/attachment.cgi?id=391101
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391101&action=review

> Source/WebCore/dom/Node.cpp:674
> +            // Update start/end for any affected Ranges

I don’t think this comment is necessary since the code says that.
If anything, we should explain why we need call this before appendData instead.

> LayoutTests/ChangeLog:17
> +        * fast/dom/Node/normalize_mutation_event.html: Added.

Please use - instead of _ in file names

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200219/e9c8ef5d/attachment.htm>


More information about the webkit-unassigned mailing list