[Webkit-unassigned] [Bug 151030] ASSERTION FAILED: roundedIntPoint(LayoutPoint(rendererMappedResult)) == result in WebCore::RenderGeometryMap::mapToContainer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151030

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #391107|review?                     |review-
              Flags|                            |

--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 391107
  --> https://bugs.webkit.org/attachment.cgi?id=391107
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391107&action=review

> Source/WebCore/rendering/RenderGeometryMap.cpp:112
> +        ASSERT(roundedIntPoint(LayoutPoint(rendererMappedResult)) == result || m_accumulatedOffsetSaturated);

I think this is a good place for ASSERT_IMPLIES:
ASSERT_IMPLIES(!m_accumulatedOffsetSaturated, LayoutPoint(rendererMappedResult)) == result)

> Source/WebCore/rendering/RenderGeometryMap.cpp:272
> +        if (m_accumulatedOffset.width().mightBeSaturated() || m_accumulatedOffset.height().mightBeSaturated())
> +            m_accumulatedOffsetSaturated = true;

Why don't we add:
LayoutSize::mightBeSaturated() which returns true if width or height are saturated, and change this to:
m_accumulatedOffsetSaturated |= m_accumulatedOffset.mightBeSaturated();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200218/21ac31ac/attachment.htm>