[Webkit-unassigned] [Bug 190841] [WinCairo] Move network process from curl network layer to WinCairo platform layer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190841

--- Comment #4 from Don Olmstead <don.olmstead at sony.com> ---
(In reply to Basuke Suzuki from comment #3)
> Comment on attachment 391030 [details]
> Move NetworkProcess initialization routine for wincairo port.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391030&action=review
> 
> This is informal review: Thanks for the patch. I think it's natural to have
> port specific initialization for Network Process even they share same
> framework.
> 
> > Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp:-41
> > -
> 
> Doesn't this break PlayStation build? I believe WebKit for PlayStation was
> landed last month.

It will yes. If there's anything that is PlayStation specific, like additional methods, those should go in a playstation/NetworkProcessPlayStation.cpp. If its just a simple thing added to one of these methods then a PLATFORM guard seems reasonable. Its hard to tell what's best without some code posted. I would suggest closing this until we land some code that touches this and then make the final decision about it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200218/c88bb81a/attachment.htm>