[Webkit-unassigned] [Bug 207889] [macOS] Don't fire timers when there is a pending rendering update

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207889

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #391044|review+                     |review-
              Flags|                            |

--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 391044
  --> https://bugs.webkit.org/attachment.cgi?id=391044
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391044&action=review

> Source/WebCore/dom/WindowEventLoop.cpp:161
> +void WindowEventLoop::spinForRenderingUpdate()
> +{
> +    // FIXME: Also bail out from the task loop in EventLoop::run().
> +    threadGlobalData().threadTimers().interruptFireLoopForRenderingUpdate();
> +}

I'm confused about the "spin" terminology. "Spin" could mean "block until something happens", like spinlock, or it could mean "allow the event loop to take a turn".

> Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:965
> +    WebCore::WindowEventLoop::spinForRenderingUpdate();

Why is this up here in TiledCoreAnimationDrawingArea? That doesn't apply to iOS. Shouldn't this mechanism be down in WebCore?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200218/cb057012/attachment.htm>