[Webkit-unassigned] [Bug 207688] [WPE] Add support for rendering progress bars

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207688

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Adrian Perez from comment #2)
> Comment on attachment 390630 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390630&action=review
> 
> Just one small nit :]
> 
> > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:263
> > +        fieldRect.setWidth(std::max<float>(2, fieldRect.width() / progressActivityBlocks));
> 
> Isn't two pixels a tad too narrow? Maybe it would make sense to
> make it slightly wider, I think something around 5 to 6px would
> be good.

I don't think so, this is the small bar that moves left -> right -> left for indeterminate progress bars. Those 2 pixels are only used when the width of the progress bar is very small.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200218/a0d45af3/attachment.htm>