[Webkit-unassigned] [Bug 207686] [WPE] Add support for rendering spin buttons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207686

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Adrian Perez from comment #2)
> Comment on attachment 390626 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390626&action=review
> 
> r+, but please check the comment below before landing.
> 
> > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:50
> > +static const unsigned menuListButtonArrowSize = 16;
> 
> Does this need to have the same value as “arrowSize“ in ThemeWPE.cpp?
> If yes, please add a comment here saying so.

Not necessarily, the arrow can be scaled, but we never scale it in case of menu list button. It's true that we don't scale it because we know the arrow size is 16 too, but still. 

> > Source/WebCore/platform/wpe/ThemeWPE.cpp:40
> > +static const unsigned arrowSize = 16;
> 
> If this needs to have the same size as “menuListButtonArrowSize” in
> RenderThemeWPE.cpp, please add a comment indicating that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200218/c49179b0/attachment-0001.htm>