[Webkit-unassigned] [Bug 207688] [WPE] Add support for rendering progress bars

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207688

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com
 Attachment #390630|review?                     |review+
              Flags|                            |

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 390630
  --> https://bugs.webkit.org/attachment.cgi?id=390630
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390630&action=review

Just one small nit :]

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:263
> +        fieldRect.setWidth(std::max<float>(2, fieldRect.width() / progressActivityBlocks));

Isn't two pixels a tad too narrow? Maybe it would make sense to
make it slightly wider, I think something around 5 to 6px would
be good.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200217/6829a402/attachment.htm>