[Webkit-unassigned] [Bug 207828] AX: Adopt _AXSCopyPathForAccessibilityBundle for WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207828

--- Comment #5 from Eric Liang <ericliang at apple.com> ---
In theory yes we should define a new HAVE, but I was trying to simplify the code, reasons:
1) HAVE_ACCESSIBILITY_BUNDLES_PATH is only used in this one place
2) _AXSAccessibilityBundlesPath() is extremely simple: it just returns "/System/Library/AccessibilitBundles" for iOS and "/System/iOSSupport/System/Library/AccessibilitBundles" for catalyst. 
3) The new _AXSCopyPathForAccessibilityBundle is also very simple: it just returns "/System/Library/AccessibilitBundles/WebProcessLoader.axbundle" for iOS and "/System/iOSSupport/System/Library/AccessibilitBundles/WebProcessLoader.axbundle" for catalyst.

Based on above three reason, my personal pref (that makes code a little bit easier to read) would be to change the old HAVE and bump to iOS 14. This way, we don't need to have three code paths (1) for less than ios13 (2) for between iOS 13 and iOS 14 (3) for iOS14 and above. Under my preferences, the code that runs in less than iOS 14 is still perfectly valid.

But if you think adding the new HAVE still makes more sense, I could for sure switch to that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200217/2eddc845/attachment-0001.htm>