[Webkit-unassigned] [Bug 207471] [WPE] Use custom theme style to render buttons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207471

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com
 Attachment #390256|review?                     |review+
              Flags|                            |

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 390256
  --> https://bugs.webkit.org/attachment.cgi?id=390256
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390256&action=review

I left just a small comment, otherwise LGTM :)

> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:54
> +static const int menuListButtonBorderSize = 1; // Keep in sync with buttonBorderSize in Theme.

I would also add a similar comment inside “ThemeWPE.cpp” warning
“Keep in sync with menuListButtonBorderSize in RenderTheme” so no
matter which file one is editing, there's always a note to ensure
that the other one is kept in sync =)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200217/07af2197/attachment-0001.htm>