[Webkit-unassigned] [Bug 191532] ASSERTION FAILED: !m_embeddedObjectsToUpdate->contains(nullptr) in WebCore::FrameView::updateEmbeddedObjects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 16 15:06:55 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=191532

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #390870|review?                     |review+
              Flags|                            |

--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 390870
  --> https://bugs.webkit.org/attachment.cgi?id=390870
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390870&action=review

> Source/WebCore/html/HTMLEmbedElement.cpp:84
> +    if (!view || (!view->inUpdateEmbeddedObjects() && !view->layoutContext().isInLayout() && !view->isPainting())) {

Can we put a helper function somewhere so we don’t need to repeat this logic in both HTMLEmbedElement and HTMLObjectElement?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200216/ede87bd2/attachment.htm>


More information about the webkit-unassigned mailing list