[Webkit-unassigned] [Bug 207664] WebKit support for Apple Pay Buttons with custom corner radii

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 14 11:52:37 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=207664

Andy Estes <aestes at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #390779|review?                     |review+
              Flags|                            |

--- Comment #6 from Andy Estes <aestes at apple.com> ---
Comment on attachment 390779
  --> https://bugs.webkit.org/attachment.cgi?id=390779
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390779&action=review

One last comment, but otherwise the patch looks great. You can upload a new patch with my named filled in to the "Reviewed by" lines in the ChangeLog. You don't need to set the review bit, but if you set the cq? bit I'll cq+ it. Thanks Nikos!

> LayoutTests/http/tests/ssl/applepay/ApplePayButton.html:55
> +                if((type == "plain" || type == "set-up")){

Why only these two types?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200214/247ad76f/attachment-0001.htm>


More information about the webkit-unassigned mailing list