[Webkit-unassigned] [Bug 207713] Fix handling of animations which lose their effect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 14 07:49:19 PST 2020


Antoine Quint <graouts at webkit.org> changed:

           What    |Removed                     |Added
                 CC|                            |graouts at webkit.org
 Attachment #390675|review?                     |review-
              Flags|                            |

--- Comment #2 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 390675
  --> https://bugs.webkit.org/attachment.cgi?id=390675

View in context: https://bugs.webkit.org/attachment.cgi?id=390675&action=review

> Source/WebCore/ChangeLog:3
> +        Fix handling of animations which lose their effect

I would suggest this bug is renamed "Ensure animations that lose their effect don't schedule an animation update". It's more descriptive of the issue that is fixed.

> Source/WebCore/ChangeLog:7
> +

You need a description for what your patch does. Something like "An active animation for which the effect is removed may be considered for an upcoming animation resolution. However, WebAnimation::timeToNextTick() expects a valid effect to be available to be able to determine timing. We now check an animation is relevant before calling timeToNextTick() and add an ASSERT() in that function to catch cases where an animation effect might not be available."

> Source/WebCore/ChangeLog:8
> +        Test: fast/animation/animation-null-effect.html

I would file this under LayoutTests/webanimations with other Web Animations tests. The fast/animation directory only contains CSS-based animations tests.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200214/ed2b903f/attachment-0001.htm>

More information about the webkit-unassigned mailing list