[Webkit-unassigned] [Bug 207491] Add canShare function for Web Share API v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 12 11:38:04 PST 2020


--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 390300
  --> https://bugs.webkit.org/attachment.cgi?id=390300

View in context: https://bugs.webkit.org/attachment.cgi?id=390300&action=review

> Source/WTF/wtf/PlatformEnable.h:723
> +#define ENABLE_FILE_SHARE 0

I wonder if we should just leave this out for now and introduce it in the next patch

> Source/WebCore/page/Navigator.cpp:114
> +    if (data.title.isNull() && data.url.isNull() && data.text.isNull()) {

Is the logic here to-spec? If you have a title and a file, we'll say `true`, right? If people are using feature detection by way of canShare, we will then be lying to them that we can share files.

> Source/WebCore/page/ShareData.h:36
> +    Vector<RefPtr<File>> files;

Is this change web-exposed? I hope people are using canShare() instead of detecting it, if it is. Not your problem, though.

> LayoutTests/imported/w3c/ChangeLog:19
> +        * web-platform-tests/web-share/share-without-user-gesture.https.html:

The test is failing on the macOS bots. You'll need to fix that before landing.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200212/84636e40/attachment.htm>

More information about the webkit-unassigned mailing list