[Webkit-unassigned] [Bug 205770] new FontFace() should not throw when failing to parse arguments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205770

Myles C. Maxfield <mmaxfield at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #390423|review?                     |review+
              Flags|                            |

--- Comment #10 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 390423
  --> https://bugs.webkit.org/attachment.cgi?id=390423
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390423&action=review

> Source/WebCore/css/CSSFontFace.cpp:728
> +    setStatus(Status::Failure);

What if it's already in the failure state? I don't think the state diagram has loops in it.

> Source/WebCore/css/FontFace.cpp:374
> +        return "U+0-10FFFF";

Shouldn't this be the empty string?

> Source/WebCore/css/FontFace.cpp:389
> +        return "normal"_s;

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200212/8a310f49/attachment-0001.htm>