[Webkit-unassigned] [Bug 207352] Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207352

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #390303|review?                     |review+
              Flags|                            |

--- Comment #28 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 390303
  --> https://bugs.webkit.org/attachment.cgi?id=390303
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390303&action=review

r=me

> Source/WebKit/Shared/ContentAsStringIncludesChildFrames.h:28
> +#include <wtf/EnumTraits.h>

Not needed.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3463
> +                    builder.append('\n');
> +                    builder.append('\n');

Are you sure you want two newlines?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200210/f95d86eb/attachment.htm>