[Webkit-unassigned] [Bug 207491] Add canShare function for Web Share API v2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207491

--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 390281
  --> https://bugs.webkit.org/attachment.cgi?id=390281
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390281&action=review

> Source/WebCore/page/Navigator.cpp:51
> +#define SUPPORT_FILE_SHARE 0
> +#define SUPPORT(FIELD) (SUPPORT_##FIELD == 1)

No idea what this is, but it doesn't look like something we do in WebKit. I'd encourage you to check out WTF's PlatformEnable*.h for how we usually do feature flags.

> Source/WebCore/page/ShareData.h:27
> +#include "File.h"

Can this be a forward declaration instead of an include (we try to limit header includes in headers to avoid the C++ build time explosion).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200210/fe458dd8/attachment.htm>