[Webkit-unassigned] [Bug 207451] New: RenderSVGShape invalidates all its resources when it needs layout, but is that necessary?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207451

            Bug ID: 207451
           Summary: RenderSVGShape invalidates all its resources when it
                    needs layout, but is that necessary?
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon.fraser at apple.com
                CC: zimmermann at kde.org

The MotionMark suits test runs by setting transforms on shapes, which does a layout. This layout invalidates all the RenderSVGShape's resources:

RenderSVGShape::layout():
...
    // Invalidate all resources of this client if our layout changed.
    if (everHadLayout() && selfNeedsLayout())
        SVGResourcesCache::clientLayoutChanged(*this);

but that doesn't seem necessary if the layout doesn't make that resource invalid (e.g. the size doesn't change).

Invalidating resources causes us to rebuild the gradients on every frame, which means making a new platform gradient.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200210/506d200e/attachment.htm>