[Webkit-unassigned] [Bug 207425] REGRESSION (r256072): ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndInputView fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207425

--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
(In reply to Wenson Hsieh from comment #3)
> This also explains the need for this snippet in the test:
> 
>     BOOL isPhone = [[UIDevice currentDevice] userInterfaceIdiom] ==
> UIUserInterfaceIdiomPhone;
>     if (isPhone)
>         EXPECT_EQ([[webView scrollView] isScrollEnabled], YES);
> 
> Since we don’t zoom on iPad, the `isZoomed` flag is NO and we don’t end up
> making the scroll view scrollable. This also suggests that if we were to
> make TestWebKitAPI a proper UI application in the future, this workaround
> could be removed.

On closer inspection, maybe not, because the test also explicitly overrides the input view and input accessory views to be empty UIViews, which means that the _inputViewBounds would be empty anyways :/

    auto inputView = adoptNS([[UIView alloc] init]);
    auto inputAccessoryView = adoptNS([[UIView alloc] init]);
    auto inputDelegate = adoptNS([TestInputDelegate new]);
    [inputDelegate setWillStartInputSessionHandler:[inputView, inputAccessoryView] (WKWebView *, id<_WKFormInputSession> session) {
        session.customInputView = inputView.get();
        session.customInputAccessoryView = inputAccessoryView.get();
    }];

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200208/d7bbfdf7/attachment-0001.htm>