[Webkit-unassigned] [Bug 187984] [Curl] Use shared single thread for WebSocket connections

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187984

--- Comment #29 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
Comment on attachment 389797
  --> https://bugs.webkit.org/attachment.cgi?id=389797
Handling connections by one thread.

View in context: https://bugs.webkit.org/attachment.cgi?id=389797&action=review

(In reply to Takashi Komori from comment #27)

> Source/WebCore/platform/network/curl/SocketStreamHandleImpl.h:65
> +    void didFail(CurlStreamID, CURLcode, URL&&) final;

> We tried to let CurlStream::Client::didXXX accept CurlStreamID as the first argument.
> But this is not used at all for now. I think we could make this change when we really need.

You said this is not used, but that's not true. This signature express that these are implemented in interfaces related to CurlStream. That is very important to read a code by others. That's the thing I feel very important.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200207/4288b6af/attachment.htm>