[Webkit-unassigned] [Bug 207352] Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 7 10:38:20 PST 2020


Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |achristensen at apple.com
 Attachment #390052|review+                     |review-
              Flags|                            |

--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 390052
  --> https://bugs.webkit.org/attachment.cgi?id=390052

View in context: https://bugs.webkit.org/attachment.cgi?id=390052&action=review

> Source/WebKit/UIProcess/WebPageProxy.h:1081
>      void getContentsAsString(WTF::Function<void (const String&, CallbackBase::Error)>&&);
> +    void getContentsAsStringInAllFrames(WTF::Function<void(const String&, CallbackBase::Error)>&&);

Instead of making a new function doing basically the same thing, could you pass a parameter?
enum class InAllFrames : bool { No, Yes };

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200207/34e7e4b8/attachment.htm>

More information about the webkit-unassigned mailing list