[Webkit-unassigned] [Bug 207352] Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207352

Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #390035|1                           |0
        is obsolete|                            |
 Attachment #390035|                            |commit-queue-
              Flags|                            |

--- Comment #8 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 390035
  --> https://bugs.webkit.org/attachment.cgi?id=390035
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390035&action=review

> Source/WebKit/UIProcess/API/C/WKPage.h:250
> +typedef void (*WKPageGetContentsAsStringInAllFramesFunction)(WKStringRef, WKErrorRef, void*);
> +WK_EXPORT void WKPageGetContentsAsStringInAllFrames(WKPageRef page, void* context, WKPageGetContentsAsStringInAllFramesFunction function);
> +

If there aren't any clients that need C API, I think we should avoid adding it (we've been pushing SPI clients towards using the more modern, Objective-C API when possible).

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3457
> +    String resultString = "";

I /think/ using StringBuilder and toString() here would be more efficient than calling String::append here, which seems to copy the contents of the string every time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200207/14da8d0a/attachment-0001.htm>