[Webkit-unassigned] [Bug 207359] Add slot based test for the accelerated animations freezing bug (201048)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207359

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #390004|review?                     |review+
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 390004
  --> https://bugs.webkit.org/attachment.cgi?id=390004
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390004&action=review

> LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:52
> +    // Put a named slot and assign an element to it.

These comments seem unnecessary? I can see that from the code.

> LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:60
> +    // Create another named slot and assign another element to it.

Ditto.

> LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:64
> +    // Start animation in the seconds slot.

Ditto.

> LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:79
> +    // Wait until animation has progressed some before snapshotting the test result.

Whereas this explanation is kind of useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200206/5bb63c27/attachment.htm>