[Webkit-unassigned] [Bug 206901] [webkitperl] Clean up webkitdirs.pm

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 6 12:18:24 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=206901

--- Comment #5 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
(In reply to Jonathan Bedard from comment #4)
> (In reply to Basuke Suzuki from comment #3)
> > (In reply to Alexey Proskuryakov from comment #2)
> > > This is going to be tough because of how webkitdirs.pm is used by into Apple
> > > internal scripts. But definitely a lot to improve here.
> > 
> > Are there a lot of changes in Apple internal branch?
> 
> It not that there are possible conflicts, it's that there is code that might
> look dead in WebKit that's actually used by Apple internal scripts, or code
> that is used by Apple internal scripts in ways that the callee is not
> expecting.

Can Apple add unit test for those? Oh, wait. There's no unittest for webkitdirs.pm lol

So deleting unused function or changing interface of existing one will be dangerous, isn't it?

Also can EWS catch those internal build break?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200206/9e87d109/attachment.htm>


More information about the webkit-unassigned mailing list