[Webkit-unassigned] [Bug 207309] New: [Cairo] Do not use old-style GNU field initializers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 5 16:36:10 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=207309

            Bug ID: 207309
           Summary: [Cairo] Do not use old-style GNU field initializers
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com

Clang is already warning about using 

  struct foo value = { member: 42 };

instead the standard syntax for field initializers should be used:

  struct foo value = { .member = 42 };

Log of warnings generated by Clang follows.

---

../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:120:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        x: cx + (r * cos(angleStart)),                                                                                                                         
        ^~                                                                                                                                                     
        .x =                                                                                                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:121:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        y: cy + (r * sin(angleStart))                                                                                                                          
        ^~                                                                                                                                                     
        .y =                                                                                                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:124:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        x: cx + (r * cos(angleStart)) - f * (r * sin(angleStart)),                                                                                             
        ^~                                                                                                                                                     
        .x =                                                                                                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:125:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        y: cy + (r * sin(angleStart)) + f * (r * cos(angleStart))                                                                                              
        ^~                                                                                                                                                     
        .y =                                                                                                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:128:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        x: cx + (r * cos(angleEnd)) + f * (r * sin(angleEnd)),                                                                                                 
        ^~                                                                                                                                                     
        .x =                                                                                                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:129:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        y: cy + (r * sin(angleEnd)) - f * (r * cos(angleEnd))                                                                                                  
        ^~                                                                                                                                                     
        .y =                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:132:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        x: cx + (r * cos(angleEnd)),
        ^~                                                                                                                                                     
        .x =                                                                                                                                                   
../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:133:9: warning: use of GNU old-style field designator extension [-Wgnu-designator]                 
        y: cy + (r * sin(angleEnd))                                                                                                                            
        ^~       
        .y = 
8 warnings generated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200206/59f0a333/attachment-0001.htm>


More information about the webkit-unassigned mailing list