[Webkit-unassigned] [Bug 207223] [WinCairo] Set up fonts for layout tests for test bot image

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 5 10:32:54 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=207223

--- Comment #6 from Stephan Szabo <stephan.szabo at sony.com> ---
Ah, sorry to be unclear, it's also used as part of the path which is used to refer to the ttf files.

For example:
https://github.com/WebKit/webkit/blob/master/Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp#L118

https://github.com/WebKit/webkit/blob/master/Tools/WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp#L135 

---

I was preferring something like the win DRT environment variable WEBKIT_TESTFONTS for finding the ttf files at runtime. 

So, the first part of the question was whether that seemed acceptable to you.

The second part of the question was whether not having the variable set could be an early out and not try to find/set up the fonts. DRT has a fallback to a exePath() + DumpRenderTree.resources if the environment variable is not set.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200205/b2b80437/attachment-0001.htm>


More information about the webkit-unassigned mailing list