[Webkit-unassigned] [Bug 187984] [Curl] Use shared single thread for WebSocket connections

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187984

--- Comment #26 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Basuke Suzuki from comment #11)
> Comment on attachment 389232 [details]
> Handling connections by one thread.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=389232&action=review
> 
> This is informal review.
> 
> > Source/WebCore/platform/network/curl/CurlStream.cpp:54
> > +    auto errorCode = m_curlHandle->perform();
> 
> You cannot try connecting here. It blocks until it connect.
> 
> > Source/WebCore/platform/network/curl/CurlStream.cpp:87
> > +    if (!m_curlHandle || m_writeBuffer)
> 
> This is wrong. If m_writeBuffer is not null, the contents of buffer is gone.
> And there's no way the client can know whether it can send or not. Add
> canSend() method or append data in the end of writeBuffer.
> 
> Or m_writeBuffer can be Vector<std::tuple<UniqueArray<uint_t>, size_t>>,
> then appending is just a simple task.
> 

Simplified m_writeBuffer by using Vector<std::tuple<UniqueArray<uint_t>, size_t>>
m_writeBuffer -> m_sendBuffer

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200205/6edce926/attachment.htm>