[Webkit-unassigned] [Bug 207181] Commit queue should never set Author to itself for someone with an svn account

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207181

--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
> https://trac.webkit.org/changeset/255552/webkit

Antoine's Bugzilla and SVN accounts are different, and since post-commit hook doesn't consult contributors.json, it doesn't know that the Bugzilla user has an active SVN account. This is fixable in code, bit not trivially. Or he could rename his Bugzilla account to match.

> https://trac.webkit.org/changeset/254659/webkit

Same for Alex.

> https://trac.webkit.org/changeset/254541/webkit

Said doesn't have an active SVN account at this time.

> Commit queue needs to fail when committing such patches if it can't correctly set the author.

The author isn't set by commit queue, but by a post commit hook. Commit queue doesn't know about SVN accounts, and the hook doesn't know about contributors.json. We will need a new mechanism for communication between them, but even then I don't see how failing to commit is preferable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200204/57738de0/attachment.htm>