[Webkit-unassigned] [Bug 207176] [OpenSSL] Implement WebCrypto APIs for AES family except AES-KW

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207176

--- Comment #3 from Yoshiaki Jitsukawa <yoshiaki.jitsukawa at sony.com> ---
Comment on attachment 389617
  --> https://bugs.webkit.org/attachment.cgi?id=389617
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389617&action=review

> Source/WebCore/crypto/openssl/CryptoAlgorithmAES_CBCOpenSSL.cpp:59
> +        return WTF::nullopt;

In this case we can return early before creating a cipher context.

> Source/WebCore/crypto/openssl/CryptoAlgorithmAES_CBCOpenSSL.cpp:64
> +

Ensure that the iv size is equal to the block size.

> Source/WebCore/crypto/openssl/CryptoAlgorithmAES_CBCOpenSSL.cpp:67
> +        return WTF::nullopt;

Shouldn't we clean up "ctx" before leaving the function? We may want to introduce a wrapper class like CairoUniquePtr or something like that.

> Source/WebCore/crypto/openssl/CryptoAlgorithmAES_CBCOpenSSL.cpp:100
> +

Please check the IV size.

It'd be nice to check if cipherSize is a multiple of the block size.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200204/beba17c1/attachment-0001.htm>