[Webkit-unassigned] [Bug 187984] [Curl] Use shared single thread for WebSocket connections

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 3 16:35:12 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=187984

--- Comment #20 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
(In reply to Takashi Komori from comment #17)
> > You cannot try connecting here. It blocks until it connect.
> 
> We tried to avoid blocking by using curl_multi_perform, but it causes some
> failures of layout tests (timeout).
> Connections made by curl_multi_perform seem to fail detecting server close.
> If you know about this, please let us know.


> > 
> > > Source/WebCore/platform/network/curl/CurlStream.cpp:153
> > > +        destroyHandle();
> > 
> > Don't you need to start any closing sequence here?
> 
> We don't need to start closing here.
> When WebSocketChannel::didReceiveSocketStreamData receives 0 byte buffer, it
> starts disconnecting.

Got it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200204/d7b98cb1/attachment.htm>


More information about the webkit-unassigned mailing list