[Webkit-unassigned] [Bug 201048] Accelerated animations freeze on render tree rebuild

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=201048

Antoine Quint <graouts at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #389514|review?                     |review+
              Flags|                            |

--- Comment #12 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 389514
  --> https://bugs.webkit.org/attachment.cgi?id=389514
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389514&action=review

> LayoutTests/webanimations/accelerated-animation-renderer-change.html:48
> +    await new Promise(resolve => setTimeout(resolve, 50));

It would be preferable to get a reference to the animation using element.getAnimations() and then wait for its ready promise to resolve and then wait one frame using requestAnimationFrame(), that way there is no setTimeout() involved.

> LayoutTests/webanimations/accelerated-animation-renderer-change.html:54
> +    await new Promise(resolve => setTimeout(resolve, 500));

Ideally we could use requestAnimationFrame here too, possibly with 2 frames to guarantee the animation would have ticked a couple of times.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200203/b6575232/attachment.htm>