[Webkit-unassigned] [Bug 187984] [Curl] Use shared single thread for WebSocket connections

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187984

--- Comment #13 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #7)
> Comment on attachment 389232 [details]
> Handling connections by one thread.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=389232&action=review
> 
> > Source/WebCore/platform/network/curl/CurlStream.cpp:82
> > +void CurlStream::send(UniqueArray<uint8_t>&& buffer, size_t length)
> 
> 'length' is redundant. buffer has the size.

UniqueArray doesn't have length property.

> > Source/WebCore/platform/network/curl/CurlStream.cpp:191
> > +void CurlStream::notifyFailWithError(CURLcode errorCode)
> 
> notifyFailWithError should be renamed because 'fail' is a verb, the phase
> 'notify fail' sounds weird.
> I think you refereed 'curlDidFailWithError'. the phase 'did fail' is not
> weird.

Changed to notifyFailure.

> 
> > Source/WebCore/platform/network/curl/CurlStreamScheduler.cpp:172
> > +    struct timeval timeout { 0, selectTimeoutMS * 1000};
> 
> You should implement self-piping technique here to wake up. (Bug 173449)
> Then, you can sleep forever here instead of waking up every 20ms.


We feel like implementing that in another ticket, because already we have had many changes.

And we think that we might be able to implement similar function by using curl_multi_poll and curl_multi_wakeup which are supported above curl 7.68.0
How do you think about using curl_multi_poo/curl_multi_wakeup?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200202/3051c657/attachment.htm>