[Webkit-unassigned] [Bug 220009] [WASM-References] Add declared function indexes set to check from what functions we can create refs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 27 04:04:48 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=220009

--- Comment #7 from Dmitry <dbezhetskov at igalia.com> ---
Comment on attachment 416503
  --> https://bugs.webkit.org/attachment.cgi?id=416503
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416503&action=review

>> Source/JavaScriptCore/wasm/WasmModuleInformation.h:78
>> +    void addDeclaredFunction(uint32_t index) { m_declaredFunctions.set(index); }
> 
> It could be a constant member function too probably?

yes, but I don't truly understand why we need to declare this as const? It is a part of ModuleInfo that we change.
btw, don't understand why addReferencedFunction is const too, do you know why it is written like that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201227/45d780e5/attachment.htm>


More information about the webkit-unassigned mailing list