[Webkit-unassigned] [Bug 220081] [CMake] Add USE_APPLE_ICU option

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220081

--- Comment #9 from monson <holymonson at gmail.com> ---
Comment on attachment 416707
  --> https://bugs.webkit.org/attachment.cgi?id=416707
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416707&action=review

>> Source/cmake/OptionsCommon.cmake:103
>> +option(USE_APPLE_ICU "Use Apple's internal ICU" ${APPLE})
> 
> Should this be in OptionsMac.cmake  instead of here?

It's not about PORT Mac but about OS(Darwin), it affects other ports. For GTK on Darwin, it usually prefers self-compiled version-specified ICU instead of the Apple one, mainly in the case of cross-platform applications keeping their dependencies unified.

An alternative to option USE_APPLE_ICU is, we search ICU normally first, if not found, then fallback to use the Apple shipped one. I can make another patch if you like this approach.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201223/503d0788/attachment.htm>